Retain ordering groups and controls#37
Open
sawpresto wants to merge 2 commits intomicrosoft:masterfrom
Open
Conversation
added 2 commits
September 6, 2019 16:05
|
|
liang2zhu1
approved these changes
Sep 9, 2019
Contributor
liang2zhu1
left a comment
liang2zhu1
left a comment
There was a problem hiding this comment.
Thanks you raising this PR - looks good to me !
|
|
||
| for (const control of group.controls) { | ||
| for (let controlIndex = 0; controlIndex < group.controls.length; controlIndex++) { | ||
| let control = group.controls[controlIndex]; |
Contributor
There was a problem hiding this comment.
nit - use const than let ?
Author
There was a problem hiding this comment.
Are you referring to changing to const control = groups.controls[controlIndex];? It looks like the compiler won't allow changing const controlIndex = 0; controlIndex < group.controls.length; controlIndex++ because it can't be incremented as constant.
Author
|
@liang2zhu1 Will this get merged or is the project inactive now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the migration for processes with both inherited and custom groups and fields, the order isn't retained so that custom fields are always last. This PR will keep the order of the fields and groups so that they are the same when migrating processes.